[Webkit-unassigned] [Bug 143953] [Curl] Favicons loaded from disc cache are ignored.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 20 10:51:12 PDT 2015


--- Comment #2 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 251165
  --> https://bugs.webkit.org/attachment.cgi?id=251165

View in context: https://bugs.webkit.org/attachment.cgi?id=251165&action=review

> Source/WebCore/platform/network/curl/CurlCacheEntry.cpp:177
>  void CurlCacheEntry::setResponseFromCachedHeaders(ResourceResponse& response)
>  {
> -    response.setHTTPStatusCode(304);
> +    response.setHTTPStatusCode(200);
> +    response.setHTTPStatusText("OK");

304 is the status of the response from the servers.  If a 304 is received from a server, then we as the browser want to tell the webpage that we got a 200 OK, right?  This makes sense, but it seems like it would've been a bigger problem.  Why wasn't this noticed before?

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150420/3efc7c28/attachment.html>

More information about the webkit-unassigned mailing list