<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [Curl] Favicons loaded from disc cache are ignored."
href="https://bugs.webkit.org/show_bug.cgi?id=143953#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [Curl] Favicons loaded from disc cache are ignored."
href="https://bugs.webkit.org/show_bug.cgi?id=143953">bug 143953</a>
from <span class="vcard"><a class="email" href="mailto:peavo@outlook.com" title="peavo@outlook.com">peavo@outlook.com</a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=143953#c2">comment #2</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=251165&action=diff" name="attach_251165" title="Patch">attachment 251165</a> <a href="attachment.cgi?id=251165&action=edit" title="Patch">[details]</a></span>
> Patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=251165&action=review">https://bugs.webkit.org/attachment.cgi?id=251165&action=review</a>
>
> > Source/WebCore/platform/network/curl/CurlCacheEntry.cpp:177
> > void CurlCacheEntry::setResponseFromCachedHeaders(ResourceResponse& response)
> > {
> > - response.setHTTPStatusCode(304);
> > + response.setHTTPStatusCode(200);
> > + response.setHTTPStatusText("OK");
>
> 304 is the status of the response from the servers. If a 304 is received
> from a server, then we as the browser want to tell the webpage that we got a
> 200 OK, right? This makes sense, but it seems like it would've been a
> bigger problem. Why wasn't this noticed before?</span >
Yes, it seems like it is only the icon loader which does not accept a 304 response. There is no problem responding with 304 for a cached document or image.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>