[Webkit-unassigned] [Bug 143807] Extract the allocation profile from JSFunction into a rare object

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=143807

--- Comment #14 from Filip Pizlo <fpizlo at apple.com> ---
(In reply to comment #12)
> Attachment 250928 [details] did not pass style-queue:
> 

Would be good to address these style issues, too.

> 
> ERROR: Source/JavaScriptCore/runtime/JSFunction.h:30:  Alphabetical sorting
> problem.  [build/include_order] [4]

We like to sort our #include's.  Sometimes editing existing code reveals past style problems - even if it's a preexisting problem, we usually fix it if style bot complains.

> ERROR: Source/JavaScriptCore/runtime/JSFunction.h:137:  The parameter name
> "exec" adds no information, so it should be removed. 

Yeah, just remove the name.

> [readability/parameter_name] [5]
> ERROR: Source/JavaScriptCore/runtime/JSCallee.h:29:  Alphabetical sorting
> problem.  [build/include_order] [4]

Ditto.

> ERROR: Source/JavaScriptCore/runtime/FunctionRareData.h:47:  The parameter
> name "vm" adds no information, so it should be removed. 
> [readability/parameter_name] [5]
> ERROR: Source/JavaScriptCore/runtime/FunctionRareData.h:76:  The parameter
> name "vm" adds no information, so it should be removed. 
> [readability/parameter_name] [5]
> ERROR: Source/JavaScriptCore/runtime/FunctionRareData.h:79:  The parameter
> name "vm" adds no information, so it should be removed. 
> [readability/parameter_name] [5]

Ditto.

> Total errors found: 6 in 23 files
> 
> 
> If any of these errors are false positives, please file a bug against
> check-webkit-style.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150416/2c38c6cd/attachment.html>