[Webkit-unassigned] [Bug 143807] Extract the allocation profile from JSFunction into a rare object

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=143807

Filip Pizlo <fpizlo at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #250928|review?, commit-queue?      |review+, commit-queue-
              Flags|                            |

--- Comment #13 from Filip Pizlo <fpizlo at apple.com> ---
Comment on attachment 250928
  --> https://bugs.webkit.org/attachment.cgi?id=250928
Hopefully final patch

View in context: https://bugs.webkit.org/attachment.cgi?id=250928&action=review

Looks great!  Please change the license and reupload.  Then I can mark cq+.

> Source/JavaScriptCore/runtime/FunctionRareData.cpp:19
> +/*
> + *  Copyright (C) 2015 Apple Inc. All rights reserved.
> + *
> + *  This library is free software; you can redistribute it and/or
> + *  modify it under the terms of the GNU Library General Public
> + *  License as published by the Free Software Foundation; either
> + *  version 2 of the License, or (at your option) any later version.
> + *
> + *  This library is distributed in the hope that it will be useful,
> + *  but WITHOUT ANY WARRANTY; without even the implied warranty of
> + *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> + *  Library General Public License for more details.
> + *
> + *  You should have received a copy of the GNU Library General Public License
> + *  along with this library; see the file COPYING.LIB.  If not, write to
> + *  the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
> + *  Boston, MA 02110-1301, USA.
> + *
> + */

Newly created files should use the 2-clause BSD license: https://www.webkit.org/coding/bsd-license.html

> Source/JavaScriptCore/runtime/FunctionRareData.h:19
> +/*
> + *  Copyright (C) 2015 Apple Inc. All rights reserved.
> + *
> + *  This library is free software; you can redistribute it and/or
> + *  modify it under the terms of the GNU Library General Public
> + *  License as published by the Free Software Foundation; either
> + *  version 2 of the License, or (at your option) any later version.
> + *
> + *  This library is distributed in the hope that it will be useful,
> + *  but WITHOUT ANY WARRANTY; without even the implied warranty of
> + *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> + *  Library General Public License for more details.
> + *
> + *  You should have received a copy of the GNU Library General Public License
> + *  along with this library; see the file COPYING.LIB.  If not, write to
> + *  the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
> + *  Boston, MA 02110-1301, USA.
> + *
> + */

Ditto.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150416/dc6fcafc/attachment.html>