<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Extract the allocation profile from JSFunction into a rare object"
href="https://bugs.webkit.org/show_bug.cgi?id=143807#c14">Comment # 14</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Extract the allocation profile from JSFunction into a rare object"
href="https://bugs.webkit.org/show_bug.cgi?id=143807">bug 143807</a>
from <span class="vcard"><a class="email" href="mailto:fpizlo@apple.com" title="Filip Pizlo <fpizlo@apple.com>"> <span class="fn">Filip Pizlo</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=143807#c12">comment #12</a>)
<span class="quote">> <span class=""><a href="attachment.cgi?id=250928&action=diff" name="attach_250928" title="Hopefully final patch">Attachment 250928</a> <a href="attachment.cgi?id=250928&action=edit" title="Hopefully final patch">[details]</a></span> did not pass style-queue:
> </span >
Would be good to address these style issues, too.
<span class="quote">>
> ERROR: Source/JavaScriptCore/runtime/JSFunction.h:30: Alphabetical sorting
> problem. [build/include_order] [4]</span >
We like to sort our #include's. Sometimes editing existing code reveals past style problems - even if it's a preexisting problem, we usually fix it if style bot complains.
<span class="quote">> ERROR: Source/JavaScriptCore/runtime/JSFunction.h:137: The parameter name
> "exec" adds no information, so it should be removed. </span >
Yeah, just remove the name.
<span class="quote">> [readability/parameter_name] [5]
> ERROR: Source/JavaScriptCore/runtime/JSCallee.h:29: Alphabetical sorting
> problem. [build/include_order] [4]</span >
Ditto.
<span class="quote">> ERROR: Source/JavaScriptCore/runtime/FunctionRareData.h:47: The parameter
> name "vm" adds no information, so it should be removed.
> [readability/parameter_name] [5]
> ERROR: Source/JavaScriptCore/runtime/FunctionRareData.h:76: The parameter
> name "vm" adds no information, so it should be removed.
> [readability/parameter_name] [5]
> ERROR: Source/JavaScriptCore/runtime/FunctionRareData.h:79: The parameter
> name "vm" adds no information, so it should be removed.
> [readability/parameter_name] [5]</span >
Ditto.
<span class="quote">> Total errors found: 6 in 23 files
>
>
> If any of these errors are false positives, please file a bug against
> check-webkit-style.</span ></pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>