[Webkit-unassigned] [Bug 143828] [WinCairo] Compile error when environment variable WEBKITLIBRARIESDIR is not defined.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=143828

Brent Fulgham <bfulgham at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #250920|review?                     |review+
              Flags|                            |

--- Comment #7 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 250920
  --> https://bugs.webkit.org/attachment.cgi?id=250920
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=250920&action=review

r=me if you get rid of the WEBKITLIBRARIESDIR portion of this change.

> Source/WebCore/AVFoundationSupport.py:34
> +    return os.path.isfile(os.environ.get('WEBKIT_LIBRARIES', '') + relativePath) or os.path.isfile(os.environ.get('WEBKITLIBRARIESDIR', '') + relativePath)

Oh! WEBKITLIBRARIESDIR is old stuff we don't use anymore (it was replaced by WEBKIT_LIBRARIES). Let's just get rid of the "WEBKITLIBRARIESDIR" part of this entirely. We don't need it, and we certainly do not want to re-introduce this old variable.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150416/55096200/attachment-0001.html>