<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:bfulgham@webkit.org" title="Brent Fulgham <bfulgham@webkit.org>"> <span class="fn">Brent Fulgham</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [WinCairo] Compile error when environment variable WEBKITLIBRARIESDIR is not defined."
href="https://bugs.webkit.org/show_bug.cgi?id=143828">bug 143828</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #250920 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [WinCairo] Compile error when environment variable WEBKITLIBRARIESDIR is not defined."
href="https://bugs.webkit.org/show_bug.cgi?id=143828#c7">Comment # 7</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [WinCairo] Compile error when environment variable WEBKITLIBRARIESDIR is not defined."
href="https://bugs.webkit.org/show_bug.cgi?id=143828">bug 143828</a>
from <span class="vcard"><a class="email" href="mailto:bfulgham@webkit.org" title="Brent Fulgham <bfulgham@webkit.org>"> <span class="fn">Brent Fulgham</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=250920&action=diff" name="attach_250920" title="Patch">attachment 250920</a> <a href="attachment.cgi?id=250920&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=250920&action=review">https://bugs.webkit.org/attachment.cgi?id=250920&action=review</a>
r=me if you get rid of the WEBKITLIBRARIESDIR portion of this change.
<span class="quote">> Source/WebCore/AVFoundationSupport.py:34
> + return os.path.isfile(os.environ.get('WEBKIT_LIBRARIES', '') + relativePath) or os.path.isfile(os.environ.get('WEBKITLIBRARIESDIR', '') + relativePath)</span >
Oh! WEBKITLIBRARIESDIR is old stuff we don't use anymore (it was replaced by WEBKIT_LIBRARIES). Let's just get rid of the "WEBKITLIBRARIESDIR" part of this entirely. We don't need it, and we certainly do not want to re-introduce this old variable.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>