[Webkit-unassigned] [Bug 143828] [WinCairo] Compile error when environment variable WEBKITLIBRARIESDIR is not defined.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=143828

--- Comment #6 from Brent Fulgham <bfulgham at webkit.org> ---
(In reply to comment #5)
> (In reply to comment #4)
> > It's hard to see how this change could have caused that test failure!
> > 
> > I'm not sure what we gain with this change. We need WEBKIT_LIBRARIES to be
> > defined, because the Visual Studio projects use it to find the property
> > sheets (e.g., 'common.props', 'debug.props') used to control much of the
> > build.
> > 
> > If we do not define WEBKIT_LIBRARIES, I would expect build failures simply
> > because the visual studio project files would not load properly.
> > 
> > Are you encountering this in conjunction with a CMake-based build? I could
> > see how that might not need the WEBKIT_LIBRARIES environment variable.
> 
> Yes, the test failure is strange :)
> 
> The problem is not WEBKIT_LIBRARIES (which I have defined), but
> WEBKITLIBRARIESDIR. I can define WEBKITLIBRARIESDIR, but maybe we don't need
> both?

Oh! I misunderstood.

We should not need both. IIRC, WEBKITLIBRARIESDIR was the 'old' name. We (rfong) switched to the newer names back in 2013. We should probably just get rid of the WEBKITLIBRARIESDIR environment variable entirely.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150416/98480c29/attachment.html>