[Webkit-unassigned] [Bug 143750] Use UNUSED_PARAM instead of the void casting to suppress unused parameter warnings

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=143750

--- Comment #12 from Gyuyoung Kim <gyuyoung.kim at webkit.org> ---
(In reply to comment #10)
> (In reply to comment #7)
> > Comment on attachment 250791 [details]
> > Patch
> > 
> > Ouch, it's so ugly. :-/ Unfortunately we can't put UNUSED_PARAM to the same
> > place as init list.
> > 
> > I think this one would be the least ugly solution
> > 
> > NotificationPermissionRequestManager::
> > NotificationPermissionRequestManager(WebPage* page)
> > {
> > #if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS)
> >     m_page = page
> > #else
> >     UNUSED_PARAM(page);
> > #endif
> > }
> 
> Agreed. But the member initialization is slightly different from the
> assignment.
> Any thoughts on this?

I think biggest difference is generally that copy constructor of *WebPage* class is called or not. In this case, however, m_page is a pointer type of *WebPage*. Thus it seems to me that there is no big difference between both.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150415/7021ad12/attachment.html>