<html>
    <head>
      <base href="https://bugs.webkit.org/" />
    </head>
    <body>
      <p>
        <div>
            <b><a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - Use UNUSED_PARAM instead of the void casting to suppress unused parameter warnings"
   href="https://bugs.webkit.org/show_bug.cgi?id=143750#c12">Comment # 12</a>
              on <a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - Use UNUSED_PARAM instead of the void casting to suppress unused parameter warnings"
   href="https://bugs.webkit.org/show_bug.cgi?id=143750">bug 143750</a>
              from <span class="vcard"><a class="email" href="mailto:gyuyoung.kim&#64;webkit.org" title="Gyuyoung Kim &lt;gyuyoung.kim&#64;webkit.org&gt;"> <span class="fn">Gyuyoung Kim</span></a>
</span></b>
        <pre>(In reply to <a href="show_bug.cgi?id=143750#c10">comment #10</a>)
<span class="quote">&gt; (In reply to <a href="show_bug.cgi?id=143750#c7">comment #7</a>)
&gt; &gt; Comment on <span class="bz_obsolete"><a href="attachment.cgi?id=250791&amp;action=diff" name="attach_250791" title="Patch">attachment 250791</a> <a href="attachment.cgi?id=250791&amp;action=edit" title="Patch">[details]</a></span>
&gt; &gt; Patch
&gt; &gt; 
&gt; &gt; Ouch, it's so ugly. :-/ Unfortunately we can't put UNUSED_PARAM to the same
&gt; &gt; place as init list.
&gt; &gt; 
&gt; &gt; I think this one would be the least ugly solution
&gt; &gt; 
&gt; &gt; NotificationPermissionRequestManager::
&gt; &gt; NotificationPermissionRequestManager(WebPage* page)
&gt; &gt; {
&gt; &gt; #if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS)
&gt; &gt;     m_page = page
&gt; &gt; #else
&gt; &gt;     UNUSED_PARAM(page);
&gt; &gt; #endif
&gt; &gt; }
&gt; 
&gt; Agreed. But the member initialization is slightly different from the
&gt; assignment.
&gt; Any thoughts on this?</span >

I think biggest difference is generally that copy constructor of *WebPage* class is called or not. In this case, however, m_page is a pointer type of *WebPage*. Thus it seems to me that there is no big difference between both.</pre>
        </div>
      </p>
      <hr>
      <span>You are receiving this mail because:</span>
      
      <ul>
          <li>You are the assignee for the bug.</li>
      </ul>
    </body>
</html>