<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Use UNUSED_PARAM instead of the void casting to suppress unused parameter warnings"
href="https://bugs.webkit.org/show_bug.cgi?id=143750#c12">Comment # 12</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Use UNUSED_PARAM instead of the void casting to suppress unused parameter warnings"
href="https://bugs.webkit.org/show_bug.cgi?id=143750">bug 143750</a>
from <span class="vcard"><a class="email" href="mailto:gyuyoung.kim@webkit.org" title="Gyuyoung Kim <gyuyoung.kim@webkit.org>"> <span class="fn">Gyuyoung Kim</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=143750#c10">comment #10</a>)
<span class="quote">> (In reply to <a href="show_bug.cgi?id=143750#c7">comment #7</a>)
> > Comment on <span class="bz_obsolete"><a href="attachment.cgi?id=250791&action=diff" name="attach_250791" title="Patch">attachment 250791</a> <a href="attachment.cgi?id=250791&action=edit" title="Patch">[details]</a></span>
> > Patch
> >
> > Ouch, it's so ugly. :-/ Unfortunately we can't put UNUSED_PARAM to the same
> > place as init list.
> >
> > I think this one would be the least ugly solution
> >
> > NotificationPermissionRequestManager::
> > NotificationPermissionRequestManager(WebPage* page)
> > {
> > #if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS)
> > m_page = page
> > #else
> > UNUSED_PARAM(page);
> > #endif
> > }
>
> Agreed. But the member initialization is slightly different from the
> assignment.
> Any thoughts on this?</span >
I think biggest difference is generally that copy constructor of *WebPage* class is called or not. In this case, however, m_page is a pointer type of *WebPage*. Thus it seems to me that there is no big difference between both.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>