[Webkit-unassigned] [Bug 143753] [GTK][W32] WTF tries to include non-existent WTFHeaderDetection.h

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=143753

Brent Fulgham <bfulgham at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #250796|review?                     |review-
              Flags|                            |

--- Comment #5 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 250796
  --> https://bugs.webkit.org/attachment.cgi?id=250796
Don't include non-existing WTF/WTFHeaderDetection.h in 2.4.x

View in context: https://bugs.webkit.org/attachment.cgi?id=250796&action=review

I don't think this is quite right. I think it would be better to have the GTK Win32 build simply generate a "false" case WTFHeaderDetection.h file. That will work with all compiler combinations. I know there are some people using MingW32 to build the WinCairo port, and others working with the Intel compiler. Now that Clang is somewhat usable on Windows, I expect that to be an issue as well.

> Source/WTF/ChangeLog:1
> +2015-04-15  Руслан Ижбулатов  <lrn1986 at gmail.com>

The string encoding here seems wrong!

> Source/WTF/wtf/Platform.h:614
> +#ifdef _MSC_VER

This change breaks the build for people using MingW32 (or other compilers) to build WebKit on Windows.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150415/51742c5d/attachment.html>