[Webkit-unassigned] [Bug 143753] [GTK][W32] WTF tries to include non-existent WTFHeaderDetection.h

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=143753

--- Comment #6 from LRN <lrn1986 at gmail.com> ---
(In reply to comment #5)
> Comment on attachment 250796 [details]
> Don't include non-existing WTF/WTFHeaderDetection.h in 2.4.x
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=250796&action=review
> 
> I don't think this is quite right. I think it would be better to have the
> GTK Win32 build simply generate a "false" case WTFHeaderDetection.h file.
> That will work with all compiler combinations. I know there are some people
> using MingW32 to build the WinCairo port, and others working with the Intel
> compiler. Now that Clang is somewhat usable on Windows, I expect that to be
> an issue as well.

I went for the simplest fix possible that does not immediately break anything else. Considering the fact that building webkit takes a few hours, i'm not very well-motivated to try anything fancier, unless i absolutely have to.

> 
> > Source/WTF/ChangeLog:1
> > +2015-04-15  Руслан Ижбулатов  <lrn1986 at gmail.com>
> 
> The string encoding here seems wrong!

Poor UTF-8 support in the review module. The text is in UTF-8 in the attachment itself.

> 
> > Source/WTF/wtf/Platform.h:614
> > +#ifdef _MSC_VER
> 
> This change breaks the build for people using MingW32 (or other compilers)
> to build WebKit on Windows.

What about #ifdef HAVE_WTFHEADERDETECTION_H and modifying these mysterious other-ports-with-buildsystems-that-use-gnu-toolchain-but-refuse-to-use-gnu-autotools-which-do-not-generate-this-header? Well, i guess they'd tell me to fix the autotools-based buildsystem used to build webkitgtk instead, which would be fair enough.

Thing is, 2.4.x is the last version to have autotools, newer webkitgtk uses cmake, and we'll go back to square one.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150415/ed8f7f44/attachment.html>