<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:bfulgham@webkit.org" title="Brent Fulgham <bfulgham@webkit.org>"> <span class="fn">Brent Fulgham</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK][W32] WTF tries to include non-existent WTFHeaderDetection.h"
href="https://bugs.webkit.org/show_bug.cgi?id=143753">bug 143753</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #250796 Flags</td>
<td>review?
</td>
<td>review-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK][W32] WTF tries to include non-existent WTFHeaderDetection.h"
href="https://bugs.webkit.org/show_bug.cgi?id=143753#c5">Comment # 5</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK][W32] WTF tries to include non-existent WTFHeaderDetection.h"
href="https://bugs.webkit.org/show_bug.cgi?id=143753">bug 143753</a>
from <span class="vcard"><a class="email" href="mailto:bfulgham@webkit.org" title="Brent Fulgham <bfulgham@webkit.org>"> <span class="fn">Brent Fulgham</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=250796&action=diff" name="attach_250796" title="Don't include non-existing WTF/WTFHeaderDetection.h in 2.4.x">attachment 250796</a> <a href="attachment.cgi?id=250796&action=edit" title="Don't include non-existing WTF/WTFHeaderDetection.h in 2.4.x">[details]</a></span>
Don't include non-existing WTF/WTFHeaderDetection.h in 2.4.x
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=250796&action=review">https://bugs.webkit.org/attachment.cgi?id=250796&action=review</a>
I don't think this is quite right. I think it would be better to have the GTK Win32 build simply generate a "false" case WTFHeaderDetection.h file. That will work with all compiler combinations. I know there are some people using MingW32 to build the WinCairo port, and others working with the Intel compiler. Now that Clang is somewhat usable on Windows, I expect that to be an issue as well.
<span class="quote">> Source/WTF/ChangeLog:1
> +2015-04-15 Ð ÑÑлан ÐжбÑлаÑов <<a href="mailto:lrn1986@gmail.com">lrn1986@gmail.com</a>></span >
The string encoding here seems wrong!
<span class="quote">> Source/WTF/wtf/Platform.h:614
> +#ifdef _MSC_VER</span >
This change breaks the build for people using MingW32 (or other compilers) to build WebKit on Windows.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>