[Webkit-unassigned] [Bug 143569] Add force property to MouseEvents

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=143569

--- Comment #15 from Beth Dakin <bdakin at apple.com> ---
Thanks Darin!

(In reply to comment #14)
> Comment on attachment 250577 [details]
> Patch that also adds force to PlatformMouseEvent
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=250577&action=review
> 
> Looks fine. Broke the iOS and Windows builds, though.
> 

I think I have those fixed now.

> > Source/WebCore/platform/PlatformMouseEvent.h:47
> > +static const double ForceAtClick = 0;
> > +static const double ForceAtForceClick = 1;
> 
> These should not be marked static, since they are in a header file.
> 

Fixed!

> > Source/WebKit2/Shared/mac/WebEventFactory.mm:378
> > +#if __MAC_OS_X_VERSION_MAX_ALLOWED >= 101003
> 
> I don’t think MAX_ALLOWED is the right way to check this. Is it?

Actually, I think it is. I did work through this with Dan and Tim. It seems like the dot releases, i.e. 101003, are only defined in the context of MAX_ALLOWED, not the usual MIN_REQUIRED.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150413/efe8bb33/attachment.html>