[Webkit-unassigned] [Bug 143569] Add force property to MouseEvents

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Apr 12 13:03:06 PDT 2015


https://bugs.webkit.org/show_bug.cgi?id=143569

Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #250577|review?                     |review+
              Flags|                            |

--- Comment #14 from Darin Adler <darin at apple.com> ---
Comment on attachment 250577
  --> https://bugs.webkit.org/attachment.cgi?id=250577
Patch that also adds force to PlatformMouseEvent

View in context: https://bugs.webkit.org/attachment.cgi?id=250577&action=review

Looks fine. Broke the iOS and Windows builds, though.

> Source/WebCore/platform/PlatformMouseEvent.h:47
> +static const double ForceAtClick = 0;
> +static const double ForceAtForceClick = 1;

These should not be marked static, since they are in a header file.

> Source/WebKit2/Shared/mac/WebEventFactory.mm:378
> +#if __MAC_OS_X_VERSION_MAX_ALLOWED >= 101003

I don’t think MAX_ALLOWED is the right way to check this. Is it?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150412/335b19b1/attachment-0001.html>


More information about the webkit-unassigned mailing list