<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Add force property to MouseEvents"
href="https://bugs.webkit.org/show_bug.cgi?id=143569#c15">Comment # 15</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Add force property to MouseEvents"
href="https://bugs.webkit.org/show_bug.cgi?id=143569">bug 143569</a>
from <span class="vcard"><a class="email" href="mailto:bdakin@apple.com" title="Beth Dakin <bdakin@apple.com>"> <span class="fn">Beth Dakin</span></a>
</span></b>
<pre>Thanks Darin!
(In reply to <a href="show_bug.cgi?id=143569#c14">comment #14</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=250577&action=diff" name="attach_250577" title="Patch that also adds force to PlatformMouseEvent">attachment 250577</a> <a href="attachment.cgi?id=250577&action=edit" title="Patch that also adds force to PlatformMouseEvent">[details]</a></span>
> Patch that also adds force to PlatformMouseEvent
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=250577&action=review">https://bugs.webkit.org/attachment.cgi?id=250577&action=review</a>
>
> Looks fine. Broke the iOS and Windows builds, though.
> </span >
I think I have those fixed now.
<span class="quote">> > Source/WebCore/platform/PlatformMouseEvent.h:47
> > +static const double ForceAtClick = 0;
> > +static const double ForceAtForceClick = 1;
>
> These should not be marked static, since they are in a header file.
> </span >
Fixed!
<span class="quote">> > Source/WebKit2/Shared/mac/WebEventFactory.mm:378
> > +#if __MAC_OS_X_VERSION_MAX_ALLOWED >= 101003
>
> I don’t think MAX_ALLOWED is the right way to check this. Is it?</span >
Actually, I think it is. I did work through this with Dan and Tim. It seems like the dot releases, i.e. 101003, are only defined in the context of MAX_ALLOWED, not the usual MIN_REQUIRED.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>