<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Add force property to MouseEvents"
href="https://bugs.webkit.org/show_bug.cgi?id=143569">bug 143569</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #250577 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Add force property to MouseEvents"
href="https://bugs.webkit.org/show_bug.cgi?id=143569#c14">Comment # 14</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Add force property to MouseEvents"
href="https://bugs.webkit.org/show_bug.cgi?id=143569">bug 143569</a>
from <span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=250577&action=diff" name="attach_250577" title="Patch that also adds force to PlatformMouseEvent">attachment 250577</a> <a href="attachment.cgi?id=250577&action=edit" title="Patch that also adds force to PlatformMouseEvent">[details]</a></span>
Patch that also adds force to PlatformMouseEvent
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=250577&action=review">https://bugs.webkit.org/attachment.cgi?id=250577&action=review</a>
Looks fine. Broke the iOS and Windows builds, though.
<span class="quote">> Source/WebCore/platform/PlatformMouseEvent.h:47
> +static const double ForceAtClick = 0;
> +static const double ForceAtForceClick = 1;</span >
These should not be marked static, since they are in a header file.
<span class="quote">> Source/WebKit2/Shared/mac/WebEventFactory.mm:378
> +#if __MAC_OS_X_VERSION_MAX_ALLOWED >= 101003</span >
I don’t think MAX_ALLOWED is the right way to check this. Is it?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>