[Webkit-unassigned] [Bug 143585] Wireless player placard for OSX

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=143585

--- Comment #3 from Roger Fong <roger_fong at apple.com> ---
(In reply to comment #2)
> Comment on attachment 250485 [details]
> patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=250485&action=review
> 
> r=me with the minor changes noted.
> 
> > Source/WebCore/Modules/mediacontrols/mediaControlsApple.js:463
> > +        inlinePlaybackPlaceholderTextTop.innerText = 'AirPlay';
> 
> This string should go into mediaControlsLocalizedStrings.js
> 
> > Source/WebCore/Modules/mediacontrols/mediaControlsApple.js:467
> > +        inlinePlaybackPlaceholderTextBottom.innerText = 'This video is playing on "AppleTV"'
> 
> Ditto.

Actually I'll just get rid of those two altogether.
We always run the updateWirelessPlaybackStatus method on initialization which initializes those values with the appropriate strings anyways.

> 
> > Source/WebCore/Modules/mediacontrols/mediaControlsApple.js:1757
> > +        console.log(deviceName);
> 
> Please remove this.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150410/72685fc4/attachment.html>