<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Wireless player placard for OSX"
href="https://bugs.webkit.org/show_bug.cgi?id=143585#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Wireless player placard for OSX"
href="https://bugs.webkit.org/show_bug.cgi?id=143585">bug 143585</a>
from <span class="vcard"><a class="email" href="mailto:roger_fong@apple.com" title="Roger Fong <roger_fong@apple.com>"> <span class="fn">Roger Fong</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=143585#c2">comment #2</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=250485&action=diff" name="attach_250485" title="patch">attachment 250485</a> <a href="attachment.cgi?id=250485&action=edit" title="patch">[details]</a></span>
> patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=250485&action=review">https://bugs.webkit.org/attachment.cgi?id=250485&action=review</a>
>
> r=me with the minor changes noted.
>
> > Source/WebCore/Modules/mediacontrols/mediaControlsApple.js:463
> > + inlinePlaybackPlaceholderTextTop.innerText = 'AirPlay';
>
> This string should go into mediaControlsLocalizedStrings.js
>
> > Source/WebCore/Modules/mediacontrols/mediaControlsApple.js:467
> > + inlinePlaybackPlaceholderTextBottom.innerText = 'This video is playing on "AppleTV"'
>
> Ditto.</span >
Actually I'll just get rid of those two altogether.
We always run the updateWirelessPlaybackStatus method on initialization which initializes those values with the appropriate strings anyways.
<span class="quote">>
> > Source/WebCore/Modules/mediacontrols/mediaControlsApple.js:1757
> > + console.log(deviceName);
>
> Please remove this.</span ></pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>