[Webkit-unassigned] [Bug 143585] Wireless player placard for OSX

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=143585

Eric Carlson <eric.carlson at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #250485|review?                     |review+
              Flags|                            |

--- Comment #2 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 250485
  --> https://bugs.webkit.org/attachment.cgi?id=250485
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=250485&action=review

r=me with the minor changes noted.

> Source/WebCore/Modules/mediacontrols/mediaControlsApple.js:463
> +        inlinePlaybackPlaceholderTextTop.innerText = 'AirPlay';

This string should go into mediaControlsLocalizedStrings.js

> Source/WebCore/Modules/mediacontrols/mediaControlsApple.js:467
> +        inlinePlaybackPlaceholderTextBottom.innerText = 'This video is playing on "AppleTV"'

Ditto.

> Source/WebCore/Modules/mediacontrols/mediaControlsApple.js:1757
> +        console.log(deviceName);

Please remove this.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150410/ae0db91a/attachment.html>