[Webkit-unassigned] [Bug 88094] Web Inspector: Add a WebInspectorServer on Linux using the GSocket API for the GTK port

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 11 08:36:01 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=88094





--- Comment #19 from Martin Robinson <mrobinson at webkit.org>  2012-09-11 08:36:24 PST ---
(From update of attachment 163316)
View in context: https://bugs.webkit.org/attachment.cgi?id=163316&action=review

>> Source/WebKit2/UIProcess/InspectorServer/gtk/WebInspectorServerGtk.cpp:51
>> +    GRefPtr<GFile> file(g_file_new_for_path(localPath.latin1().data()));
> 
> Use adoptGRef() to avoid leaking the GFile. GFile expects UTF-8 so you should use localPath.utf8().data() instead of latin1

This is an awesome review, but I just thought it'd be good to point out here that GFile accepts the "glib filename encoding" which isn't necessarily UTF-8. Instead you should use fileSystemRepresentation from FileSystemGtk.cpp to convert from a String to a CString.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list