[Webkit-unassigned] [Bug 88094] Web Inspector: Add a WebInspectorServer on Linux using the GSocket API for the GTK port

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=88094





--- Comment #18 from Anton Obzhirov <a.obzhirov at samsung.com>  2012-09-11 08:14:22 PST ---
(From update of attachment 163316)
View in context: https://bugs.webkit.org/attachment.cgi?id=163316&action=review

>> Source/WebCore/platform/network/soup/SocketStreamHandleSoup.cpp:116
>> +    m_client->didOpenSocketStream(this);
> 
> Instead of duplicating all this code, since the socket is already connected this could be just:
> 
> m_id = activateHandle(this);
> connected(socketConnection, 0);
> 
> For this to work, we would also need to fix connectedCallback() to use GRefPtr and adopGRef for the socket connection (note that it's leaked in case of error), and take a ref instead of adopting it in connected().

Yep, I realized I should have call connected() here. Original version of this function before few patches was a bit different. :)

>> Source/WebKit2/UIProcess/InspectorServer/gtk/WebSocketServerGtk.cpp:57
>> +    g_object_ref_sink(connection);
> 
> Don't do this, pass the connection to SocketStreamHandle::create() and the constructor will tak a reference.

OK, makes sense which changes above,

>> Source/WebKit2/UIProcess/InspectorServer/qt/WebInspectorServerQt.cpp:50
>> +    String localPath = (path == "/") ? "/webkit/inspector/inspectorPageIndex.html" : path;
> 
> Is this a bug in Qt implementation or something that has changed in this patch?

GTK and QT ports will share inspectorPageIndex.html. I moved the file in generic location (see previous reviews)

>> Source/WebKit2/UIProcess/gtk/WebContextGtk.cpp:66
>> +    initialized = WebInspectorServer::shared().listen(bindAddress, port);
> 
> Do we want this even if the env variable is not present?

I think so. It will be bound to 127.0.0.1 by default. It basically copies QT port behavior here.

.

>> Source/WebKit2/UIProcess/gtk/WebContextGtk.cpp:78
>> +    initInspectorServer();
> 
> How is the inspector server run? does it run in the UI process?

Yes, as a part of GTK main loop in UI process.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.