[Webkit-unassigned] [Bug 80760] WinLauncher should show loading errors

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Mar 11 09:09:09 PDT 2012


Patrick R. Gansterer <paroga at paroga.com> changed:

           What    |Removed                     |Added
 Attachment #131215|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |

--- Comment #10 from Patrick R. Gansterer <paroga at paroga.com>  2012-03-11 09:09:09 PST ---
(From update of attachment 131215)
View in context: https://bugs.webkit.org/attachment.cgi?id=131215&action=review

AFAIK we usually DO NOT commit any whitespace only changes -> unusally we remove it when we touch a line (+/- a few lines) which contains whitespace
whitspace is not nice, but does not hurt anybody during development, but it creates unneded chages which make digging in svn log more complicated

> Tools/WinLauncher/WinLauncher.cpp:145
> +HRESULT WinLauncherWebHost::didFailProvisionalLoadWithError(IWebView *webView, IWebError *error)

why do you still add this change? this and the other patch won't apply as two independed changes (IMHO that's what brent requested)

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list