[Webkit-unassigned] [Bug 80760] WinLauncher should show loading errors

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Mar 11 09:03:32 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=80760


Patrick R. Gansterer <paroga at paroga.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #131214|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #9 from Patrick R. Gansterer <paroga at paroga.com>  2012-03-11 09:03:32 PST ---
(From update of attachment 131214)
View in context: https://bugs.webkit.org/attachment.cgi?id=131214&action=review

> Tools/WinLauncher/WinLauncher.cpp:145
> +HRESULT WinLauncherWebHost::didFailProvisionalLoadWithError(IWebView *webView, IWebError *error)

unuesed parameter webView

> Tools/WinLauncher/WinLauncher.cpp:147
> +    BSTR frameURL = 0;

unused variable frameURL

> Tools/WinLauncher/WinLauncher.cpp:149
> +    HRESULT hr = error->localizedDescription(&errorDescription);

unused variable hr -> please handle a possible error

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list