[Webkit-unassigned] [Bug 80760] WinLauncher should show loading errors

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=80760





--- Comment #11 from Ashod Nakashian <ashodnakashian at yahoo.com>  2012-03-11 09:39:49 PST ---
(In reply to comment #10)
> (From update of attachment 131215 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=131215&action=review
> 
> AFAIK we usually DO NOT commit any whitespace only changes -> unusally we remove it when we touch a line (+/- a few lines) which contains whitespace
> whitspace is not nice, but does not hurt anybody during development, but it creates unneded chages which make digging in svn log more complicated

Fair enough. I'll limit changes to the lines I touch and nearby where reasonable.

> 
> > Tools/WinLauncher/WinLauncher.cpp:145
> > +HRESULT WinLauncherWebHost::didFailProvisionalLoadWithError(IWebView *webView, IWebError *error)
> 
> why do you still add this change? this and the other patch won't apply as two independed changes (IMHO that's what brent requested)

Because I assume if these two patches are applied after one another, they should contain incremental changes. May be I messed it up while generating the patch, but that was the rationale.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.