[Webkit-unassigned] [Bug 88631] [EFL][WK2] Add ewk_view_touchscreen which has touchscreen behavior.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=88631





--- Comment #7 from EunMi Lee <eunmi15.lee at samsung.com>  2012-06-14 05:35:34 PST ---
(In reply to comment #5)
> (From update of attachment 146808 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=146808&action=review
> 
> > Source/WebKit2/UIProcess/API/efl/ewk_view.h:165
> > +EAPI Eina_Bool ewk_view_smart_class_init(Ewk_View_Smart_Class *api);
> 
> WebKit/Efl have similar API, ewk_view_base_smart_set.
> 
> Isn't it better to make them similar (or same)?

I think ewk_view_smart_class_set() is better, so I will change to that.
I don't want to add "base" to the name because ewk_view is not a base object in the WebKit2. (it is base in the WebKit1)
and, I agree that "set" is better than "init" :)

> 
> > Source/WebKit2/UIProcess/API/efl/ewk_view_touchscreen.cpp:23
> > +#include "NotImplemented.h"
> 
> <WebCore/NotImplemented.h> looks better.

OK, I will change to that.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.