[Webkit-unassigned] [Bug 88631] [EFL][WK2] Add ewk_view_touchscreen which has touchscreen behavior.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=88631





--- Comment #6 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2012-06-11 23:46:59 PST ---
(From update of attachment 146808)
View in context: https://bugs.webkit.org/attachment.cgi?id=146808&action=review

> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:101
> +static bool g_enableTouchscreen = false;

AFAIK, g_ is not WebKit coding style. If I am this patch owner, I would implement this by using enum type.

For example,
  enum Mode { TouchScreenMode, NormalMode };

> Source/WebKit2/UIProcess/API/efl/ewk_view.h:151
> + * Sets the smart class api, enabling view to be inherited.

s/api/API/g

> Source/WebKit2/UIProcess/API/efl/ewk_view_touchscreen.cpp:35
> +    // The ewk_view_touchscreen does not support mouse wheel event.

Using FIXME:

> Source/WebKit2/UIProcess/API/efl/ewk_view_touchscreen.cpp:42
> +    return true;

Is *false* better than *true* ?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.