[Webkit-unassigned] [Bug 88631] [EFL][WK2] Add ewk_view_touchscreen which has touchscreen behavior.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 14 05:47:27 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=88631





--- Comment #8 from EunMi Lee <eunmi15.lee at samsung.com>  2012-06-14 05:47:26 PST ---
(In reply to comment #6)
> (From update of attachment 146808 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=146808&action=review
> 
> > Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:101
> > +static bool g_enableTouchscreen = false;
> 
> AFAIK, g_ is not WebKit coding style. If I am this patch owner, I would implement this by using enum type.
> 
> For example,
>   enum Mode { TouchScreenMode, NormalMode };
> 

OK, I will try to change static variable using DEFINE_STATIC_LOCAL() and enum. :)

> > Source/WebKit2/UIProcess/API/efl/ewk_view.h:151
> > + * Sets the smart class api, enabling view to be inherited.
> 
> s/api/API/g
>

OK.

> > Source/WebKit2/UIProcess/API/efl/ewk_view_touchscreen.cpp:35
> > +    // The ewk_view_touchscreen does not support mouse wheel event.
> 
> Using FIXME:

OK.

> 
> > Source/WebKit2/UIProcess/API/efl/ewk_view_touchscreen.cpp:42
> > +    return true;
> 
> Is *false* better than *true* ?

Yes, right. false is better. I will change to false.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list