[Webkit-unassigned] [Bug 91688] [chromium] Add CCScrollbarAnimationController class for compositor scrollbar animation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=91688





--- Comment #12 from Adrienne Walker <enne at google.com>  2012-07-27 12:46:51 PST ---
(From update of attachment 154800)
View in context: https://bugs.webkit.org/attachment.cgi?id=154800&action=review

I would really like a unit test for CCScrollbarAnimationControllerAndroid.  If somebody refactors something and it breaks, then we won't know.

Could you refactor CCScrollbarAnimationControllerAndroid into a CCScrollbarAnimationControllerLinearFade(float hideDelay, float fadeoutLen) and then have Android just instantiate that with the values that it needs? This would let you test that this class has reasonable opacity values and handles pinches correctly on all platforms.

> Source/WebKit/chromium/tests/ScrollbarLayerChromiumTest.cpp:163
> +    scrollbarController->updateScrollOffset(ccLayerTreeRoot.get());

Why do you need to call this explicitly in this test?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.