[Webkit-unassigned] [Bug 91688] [chromium] Add CCScrollbarAnimationController class for compositor scrollbar animation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=91688





--- Comment #13 from Tien-Ren Chen <trchen at chromium.org>  2012-07-27 15:29:53 PST ---
(In reply to comment #10)
> Ah, I see you've rebased it.  Any idea what's up with the test?

Ah, the CCLayerImplTest.verifyLayerChangesAreTrackedProperly failure is an interesting one.

I added early exit for CCLayerImpl::scrollBy so it becomes a no-op if newDelta == m_scrollDelta. We never set scrollMaximum on the layer in the test, thus scrollBy exits early and none of the layers are marked as changed.

Does it break any assumption to do an early exit in scrollBy?

(In reply to comment #12)
> (From update of attachment 154800 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=154800&action=review
> 
> I would really like a unit test for CCScrollbarAnimationControllerAndroid.  If somebody refactors something and it breaks, then we won't know.
> 
> Could you refactor CCScrollbarAnimationControllerAndroid into a CCScrollbarAnimationControllerLinearFade(float hideDelay, float fadeoutLen) and then have Android just instantiate that with the values that it needs? This would let you test that this class has reasonable opacity values and handles pinches correctly on all platforms.

Sounds like a great way to reuse the code!

I think we want to verify that the scrollbar will show in responding to the user gesture, and will eventually fade out as time goes. Is there a good way to simulate monotonicallyIncreasingTime()?

> > Source/WebKit/chromium/tests/ScrollbarLayerChromiumTest.cpp:163
> > +    scrollbarController->updateScrollOffset(ccLayerTreeRoot.get());
> 
> Why do you need to call this explicitly in this test?

No we don't, and I agree it's probably wrong to require so. Fixed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.