[Webkit-unassigned] [Bug 91688] [chromium] Add CCScrollbarAnimationController class for compositor scrollbar animation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=91688





--- Comment #11 from Tien-Ren Chen <trchen at chromium.org>  2012-07-27 12:43:25 PST ---
(In reply to comment #9)
> (From update of attachment 154796 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=154796&action=review
> 
> I like, but please split the FrameView.cpp changes into a different bug and rebase this patch (it seems to not apply and may have bitrotted a bit).
> > Source/WebCore/page/FrameView.cpp:647
> > +// On Android (and potentially other platform that supports pinch zoom) 
> > +// the main frame should always create scrollbars unless hidden explicitly,
> > +// as the viewport size can change in the compositor
> 
> can you split this change into a separate patch where we can discuss the right way to do this?

Roger that, will split the patch.

(In reply to comment #10)
> Ah, I see you've rebased it.  Any idea what's up with the test?

For the unit tests I probably forgot to update some of the tests. As for layout test it seems to be some RenderText is off by one pixel, probably irrelevant. let's see if the error persists.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.