[Webkit-unassigned] [Bug 90954] [EFL] Add const to the parameter of getters in ewk_security_origin

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=90954





--- Comment #13 from Kihong Kwon <kihong.kwon at samsung.com>  2012-07-12 00:27:38 PST ---
(In reply to comment #12)
> (From update of attachment 151842 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=151842&action=review
> 
> > Source/WebKit/efl/ewk/ewk_security_origin.cpp:44
> >      return origin->protocol;
> 
> Are you sure that origin points out to correct pointer? I'd rather add null checking here as this is API - we should protect it.

The description about eina_stringshare_add is "A pointer to an instance of the string on success. NULL on failure."
It means, if pointer of Ewk_Security_Origin is available, there is no problem with this API.

> 
> > Source/WebKit/efl/ewk/ewk_security_origin.cpp:49
> >      return origin->host;
> 
> Ditto.
> 
> > Source/WebKit/efl/ewk/ewk_security_origin.h:52
> > + * @return the protocol scheme or 0 if there is not a protocol scheme.
> 
> Please add @c to 0 and do not use dots in return/param descriptions.

OK.
> 
> > Source/WebKit/efl/ewk/ewk_security_origin.h:64
> > + * @return the host domain or 0 if there is not a host scheme.
> 
> Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.