[Webkit-unassigned] [Bug 90954] [EFL] Add const to the parameter of getters in ewk_security_origin

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=90954





--- Comment #14 from Grzegorz Czajkowski <g.czajkowski at samsung.com>  2012-07-12 00:40:19 PST ---
(In reply to comment #13)
> (In reply to comment #12)
> > (From update of attachment 151842 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=151842&action=review
> > 
> > > Source/WebKit/efl/ewk/ewk_security_origin.cpp:44
> > >      return origin->protocol;
> > 
> > Are you sure that origin points out to correct pointer? I'd rather add null checking here as this is API - we should protect it.
> 
> The description about eina_stringshare_add is "A pointer to an instance of the string on success. NULL on failure."
> It means, if pointer of Ewk_Security_Origin is available, there is no problem with this API.

I didn't mean about eina_stringshare behavior in case of NULL but about 'origin' pointer. What will happen if application calls ewk_security_origin_protocol_get(0) ?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.