[Webkit-unassigned] [Bug 90954] [EFL] Add const to the parameter of getters in ewk_security_origin

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=90954





--- Comment #12 from Grzegorz Czajkowski <g.czajkowski at samsung.com>  2012-07-11 23:45:52 PST ---
(From update of attachment 151842)
View in context: https://bugs.webkit.org/attachment.cgi?id=151842&action=review

> Source/WebKit/efl/ewk/ewk_security_origin.cpp:44
>      return origin->protocol;

Are you sure that origin points out to correct pointer? I'd rather add null checking here as this is API - we should protect it.

> Source/WebKit/efl/ewk/ewk_security_origin.cpp:49
>      return origin->host;

Ditto.

> Source/WebKit/efl/ewk/ewk_security_origin.h:52
> + * @return the protocol scheme or 0 if there is not a protocol scheme.

Please add @c to 0 and do not use dots in return/param descriptions.

> Source/WebKit/efl/ewk/ewk_security_origin.h:64
> + * @return the host domain or 0 if there is not a host scheme.

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.