[Webkit-unassigned] [Bug 54623] RTL web content should have left-hand scrollbar.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54623





--- Comment #46 from Hironori Bono <hbono at chromium.org>  2012-01-31 01:59:28 PST ---
Greetings Niwa-san,

Many thanks for your comments.
Is it possible to clarify a couple of your comments before applying them?

(In reply to comment #45)
> Can we move !style()->isLeftToRightDirection() to the outer if-statement so that we don't make an extra function call to addOverflowFromChild?

Does this mean we just call addOverflowFromChild(positionedObject) (not addOverflowFromChild(positionedObject, IntSize(...))) when !style()->isLeftToRightDirection() is true? (We need to call addOverflowFromChild  itself for non-fixed objects as the original code calls.)

> > Source/WebCore/rendering/RenderBlock.cpp:1898
> > +    if (!style()->isLeftToRightDirection() && style()->isHorizontalWritingMode())
> 
> Instead of duplicating this condition throughout the codebase, can we add an inline function to wrap it?
> e.g. style()->shouldPlaceVerticalScrollbarOnLeft()

In my personal opinion, I wonder if we can call this function 'vertical'. When -webkit-writing-mode is vertical-rl or vertical-lr, this scrollbar is used for scrolling text "horizontally". For example, when we open "LayoutTests/fast/overflow/overflow-rtl-vertical.html" on Safari, it shows a scrollbar above its text. When we apply my patch v8, it moves the scrollbar below its text.

Regards,

Hironori Bono

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.