[Webkit-unassigned] [Bug 54623] RTL web content should have left-hand scrollbar.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 31 11:37:50 PST 2012


--- Comment #47 from Ryosuke Niwa <rniwa at webkit.org>  2012-01-31 11:37:49 PST ---
(In reply to comment #46)
> (In reply to comment #45)
> > Can we move !style()->isLeftToRightDirection() to the outer if-statement so that we don't make an extra function call to addOverflowFromChild?
> Does this mean we just call addOverflowFromChild(positionedObject) (not addOverflowFromChild(positionedObject, IntSize(...))) when !style()->isLeftToRightDirection() is true? (We need to call addOverflowFromChild  itself for non-fixed objects as the original code calls.)

Sorry, that comment seems bogus. What I really meant is move "if (positionedObject->style()->position() != FixedPosition)" outside of if-defs to be shared. Then, you only need to wrap two lines inside if-defs (x -= verticalScrollbarWidth(); and if before that).

> > > Source/WebCore/rendering/RenderBlock.cpp:1898
> > > +    if (!style()->isLeftToRightDirection() && style()->isHorizontalWritingMode())
> > 
> > Instead of duplicating this condition throughout the codebase, can we add an inline function to wrap it?
> > e.g. style()->shouldPlaceVerticalScrollbarOnLeft()
> In my personal opinion, I wonder if we can call this function 'vertical'. When -webkit-writing-mode is vertical-rl or vertical-lr, this scrollbar is used for scrolling text "horizontally". For example, when we open "LayoutTests/fast/overflow/overflow-rtl-vertical.html" on Safari, it shows a scrollbar above its text. When we apply my patch v8, it moves the scrollbar below its text.

Hm... how about shouldPlaceBlockDirectionScrollbarOnLogicalLeft() then ?

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list