[Webkit-unassigned] [Bug 54623] RTL web content should have left-hand scrollbar.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54623





--- Comment #45 from Ryosuke Niwa <rniwa at webkit.org>  2012-01-30 10:52:26 PST ---
(From update of attachment 122368)
View in context: https://bugs.webkit.org/attachment.cgi?id=122368&action=review

Does your patch work for a block with writing-mode: bt-rl?

> Source/WebCore/rendering/RenderBlock.cpp:1497
> +            if (!style()->isLeftToRightDirection() && style()->isHorizontalWritingMode())

Can we move !style()->isLeftToRightDirection() to the outer if-statement so that we don't make an extra function call to addOverflowFromChild?

> Source/WebCore/rendering/RenderBlock.cpp:1898
> +    if (!style()->isLeftToRightDirection() && style()->isHorizontalWritingMode())

Instead of duplicating this condition throughout the codebase, can we add an inline function to wrap it?
e.g. style()->shouldPlaceVerticalScrollbarOnLeft()

> Source/WebCore/rendering/RenderBox.cpp:1232
>      // Subtract out scrollbars if we have them.

You should add an early exit when !layer() to avoid duplicating the if-statement.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.