[Webkit-unassigned] [Bug 73215] [Qt][WK2] Split QWebPermissionRequest into QWebSecurityOrigin

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=73215





--- Comment #31 from Adenilson Cavalcanti Silva <savagobr at yahoo.com>  2012-01-22 10:46:46 PST ---
Rafael

Thanks for the comments. I will answer inline.

(In reply to comment #29)
> (From update of attachment 123470 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=123470&action=review
> 
> I couldn't look into the whole patch, but just giving an informal review anyway... Besides the test is there, they don't really cover what should be tested there.
> 

What is not covered? Do you mean all the remaining properties? Or something else?

> > Source/WebKit2/UIProcess/API/qt/qtwebsecurityorigin.cpp:133
> > +            return m_url.path() == QFileInfo(m_url.path()).canonicalFilePath();
> 
> You could eliminate the "else" because getting into the condition of the previous if would have early returned anyway. :)

Indeed.

> 
> > Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_origin.qml:41
> > +            compare(webView.success, true)
> 
> So how exactly are we testing the case when webView.success is false (you set it in this test but you don't use it)?

The idea is that the test will fail if the reported url port/scheme is different from the expected value (then webView.success is set to false inside the if clause in onPermissionRequested).

The default behavior for the test is to succeed, this is why compare checks for true. If different, the test fails, since it will eval to: compare(false, true).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.