[Webkit-unassigned] [Bug 73215] [Qt][WK2] Split QWebPermissionRequest into QWebSecurityOrigin

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=73215





--- Comment #32 from Adenilson Cavalcanti Silva <savagobr at yahoo.com>  2012-01-22 10:57:13 PST ---
Alexander

Thanks for the comments, answers inline.

> 
> > Source/WebKit2/UIProcess/API/qt/qtwebsecurityorigin.cpp:24
> > +#include <KURL.h>
> 
> Is this really needed?

Good point! I will remove it.

> 
> > Source/WebKit2/UIProcess/API/qt/qtwebsecurityorigin.cpp:44
> > +    return (scheme == QString::fromUtf8("qrc")) ? true : (scheme == QString::fromUtf8("file"));
> 
> Couldn't you do something like: return scheme == QLatin1String("qrc") || scheme == QLatin1String("file"); ?

Checking in Qt Assistant it seems that using QLatin1String should be faster than creating a new QString object (which is what the code was doing).

I will change it too.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.