[Webkit-unassigned] [Bug 73215] [Qt][WK2] Split QWebPermissionRequest into QWebSecurityOrigin

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=73215





--- Comment #30 from Alexander Færøy <ahf at 0x90.dk>  2012-01-22 10:01:47 PST ---
(From update of attachment 123470)
View in context: https://bugs.webkit.org/attachment.cgi?id=123470&action=review

> Source/WebKit2/UIProcess/API/qt/qtwebsecurityorigin.cpp:24
> +#include <KURL.h>

Is this really needed?

> Source/WebKit2/UIProcess/API/qt/qtwebsecurityorigin.cpp:44
> +    return (scheme == QString::fromUtf8("qrc")) ? true : (scheme == QString::fromUtf8("file"));

Couldn't you do something like: return scheme == QLatin1String("qrc") || scheme == QLatin1String("file"); ?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.