[Webkit-unassigned] [Bug 73215] [Qt][WK2] Split QWebPermissionRequest into QWebSecurityOrigin

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=73215





--- Comment #29 from Rafael Brandao <rafael.lobo at openbossa.org>  2012-01-22 08:58:34 PST ---
(From update of attachment 123470)
View in context: https://bugs.webkit.org/attachment.cgi?id=123470&action=review

I couldn't look into the whole patch, but just giving an informal review anyway... Besides the test is there, they don't really cover what should be tested there.

> Source/WebKit2/UIProcess/API/qt/qtwebsecurityorigin.cpp:133
> +            return m_url.path() == QFileInfo(m_url.path()).canonicalFilePath();

You could eliminate the "else" because getting into the condition of the previous if would have early returned anyway. :)

> Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_origin.qml:41
> +            compare(webView.success, true)

So how exactly are we testing the case when webView.success is false (you set it in this test but you don't use it)?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.