[Webkit-unassigned] [Bug 63062] Add capture attribute for HTML Media Capture

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=63062





--- Comment #36 from Jongseok Yang <js45.yang at samsung.com>  2012-02-17 23:20:15 PST ---
(In reply to comment #33)

Thank you for your review. 
Could you please check my comment?


> (From update of attachment 127553 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=127553&action=review
> 
> Please announce this feature to webkit-dev.
> http://www.webkit.org/coding/adding-features.html
> 

I will that.

> Does MedieaCaptureChooser set a file name to FileChooerClient?  If so, who removes the file? <input type=file> shows a file name for a captured data?
> 

Yes. a file name is set using chooseFile() of MedieaCaptureChooser.
I think that WebKit need not consider who removes the file. WebKit supports download feature but does not manage the downloaded files. 
I think that the feature is similar to the function of "photo" menu in facebook mobile application. The application like facebook mobile application don't care to manage the taken picture. I think it is just the check point of the platform.

> > Source/WebCore/platform/FileChooser.cpp:72
> > +    if (equalIgnoringCase(input->capture(), MediaCaptureNames::camera())) {
> 
> input->capture() should be input->fastGetAttribute(captureAttr), and should remove HTMLInputElement::capture().
> Anyway, this is a layering violation.

capture() is the wrapper function for fastGetAttribute(captureAttr). I observed the same logic from HTMLInputElement::accept(), HTMLInputElement::alt() and HTMLInputElement::multiple(). Do you mean that these functions are also layering violation?

> 
> > Source/WebCore/platform/FileChooser.h:74
> > +    MediaCaptureType determineCaptureType(HTMLInputElement*);
> 
> Layering violation.  We must not use WebCore/html/* classes in WebCore/platform/* files.

I will fix that.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.