[Webkit-unassigned] [Bug 63062] Add capture attribute for HTML Media Capture

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=63062





--- Comment #35 from Jongseok Yang <js45.yang at samsung.com>  2012-02-17 22:41:30 PST ---
(In reply to comment #31)
> (In reply to comment #30)
> 
> Thank you for your review. It was a good help in my patch. 
> 
> I have some question about your comment. Could you please give me an answer?
> 
> 
> > (From update of attachment 127553 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=127553&action=review
> > 
> > Thanks for the latest patch Jongseok! This looks closer to me to what the original reviewers were looking for. I am not a reviewer so cannot formally review the patch, but I have a few comments and will defer back to the original reviewers for their thoughts. Sam, would you mind taking another look at this?
> > 
> > Cheers, Ben
> > 
> > > Source/WebCore/platform/FileChooser.cpp:64
> > > +    return static_cast<MediaCaptureChooser*>(m_chooser.get());
> > 
> > Don't think the static_cast is needed?
> > 
> I'll fix that.
> 

Well, I got the build break when removing static_cast. Please check it again.

> 
> > > Source/WebCore/platform/FileChooser.cpp:73
> > > +        for (Vector<String>::const_iterator iterator = input->acceptMIMETypes().begin(); iterator != input->acceptMIMETypes().end(); ++iterator)
> > 
> > Could this be replaced with something like:
> > if (MIMETypeRegistry::isSupportCaptureType("image/*") && input->acceptMIMETypes().contains("image/*)) ?
> > 
> Could you please check the URL? 
> (http://lists.w3.org/Archives/Public/public-device-apis/2011Apr/0013.html)
> I'd like to implement a good solution to meet the editor's idea.
> Could you please give me your idea?
> 
> 
> > > Source/WebCore/platform/FileChooser.h:44
> > > +#endif
> > 
> > Maybe merge these two #ifdef blocks?
> > 
> > > Source/WebCore/platform/FileChooser.h:51
> > > +    Microphone,
> > 
> > These should probably be in alphabetical order.
> >
> Do you mean that named types in enum should be sorted? I observed that there are many enum types that they don't meet the coding style. 
> Could you please clarify the coding style?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.