[Webkit-unassigned] [Bug 63062] Add capture attribute for HTML Media Capture

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=63062





--- Comment #37 from Kent Tamura <tkent at chromium.org>  2012-02-19 21:39:35 PST ---
(In reply to comment #36)

I took a look at the draft.
 - The draft is old.  Is the WG working on it actively?
 - We should support media capture regardless of existence of 'capture' attribute.
  http://www.w3.org/TR/2011/WD-html-media-capture-20110414/#formaccess
 - I don't think we need to use both of Chrome::runOpenPanel and Chrome::runCapturePanel. runCapturePanel should support file choosing, and we should always use Chrome::runCapturePanel if ENABLE_HTML_MEDIA_CAPTURE.
 - I don't think showing a captured file name makes sense. We had better show a captured media information such as:
   "1280x768 still image (123KB)" (with a thumbnail?)
   "35 second audio (63KB)"

> > > Source/WebCore/platform/FileChooser.cpp:72
> > > +    if (equalIgnoringCase(input->capture(), MediaCaptureNames::camera())) {
> > 
> > input->capture() should be input->fastGetAttribute(captureAttr), and should remove HTMLInputElement::capture().
> > Anyway, this is a layering violation.
> 
> capture() is the wrapper function for fastGetAttribute(captureAttr). I observed the same logic from HTMLInputElement::accept(), HTMLInputElement::alt() and HTMLInputElement::multiple(). Do you mean that these functions are also layering violation?

I meant using HTMLInputElement in platform/FileChooser.cpp was a layering violation.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.