[Webkit-unassigned] [Bug 77833] Get rid of Source/autotools/webkit.m4

Mon Feb 6 00:52:34 PST 2012

https://bugs.webkit.org/show_bug.cgi?id=77833

--- Comment #8 from Martin Robinson <mrobinson at webkit.org>  2012-02-06 00:52:34 PST ---
(In reply to comment #7)

> > > configure.ac:394
> > > +PKG_CHECK_MODULES([GLIB], [glib-2.0 >= $GLIB_REQUIRED_VERSION])
> > 
> > I believe it's better to use AM_PATH_GLIB_2_0($GLIB_REQUIRED_VERSION) here, because it has support for pulling in GLib modules individually. See http://trac.webkit.org/changeset/106485. I'd like to have this patch in master too.
> 
> How about this then:
> PKG_CHECK_MODULES([GLIB], [glib-2.0 >= $GLIB_REQUIRED_VERSION
>     gmodule-2.0 gobject-2.0 gthread-2.0 gio-2.0])

It seems better to use the autoconfig glue that GLib provides. Is there any reason the PKG_CHECK_MODULES version is superior?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.