[Webkit-unassigned] [Bug 77833] Get rid of Source/autotools/webkit.m4

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=77833





--- Comment #7 from Priit Laes (IRC: plaes) <plaes at plaes.org>  2012-02-06 00:44:54 PST ---
(In reply to comment #6)
> (From update of attachment 125532 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=125532&action=review
> 
> This is a really great cleanup.
> 
> > Source/autotools/webkit.m4:-7
> > -m4_define([initialized], [no])
> 
> Why can we remove this?

I assume its original purpose was checking whether WEBKIT_INIT had been already called. And I couldn't find it used anywhere else.

> 
> > configure.ac:394
> > +PKG_CHECK_MODULES([GLIB], [glib-2.0 >= $GLIB_REQUIRED_VERSION])
> 
> I believe it's better to use AM_PATH_GLIB_2_0($GLIB_REQUIRED_VERSION) here, because it has support for pulling in GLib modules individually. See http://trac.webkit.org/changeset/106485. I'd like to have this patch in master too.

How about this then:
PKG_CHECK_MODULES([GLIB], [glib-2.0 >= $GLIB_REQUIRED_VERSION
    gmodule-2.0 gobject-2.0 gthread-2.0 gio-2.0])

> > configure.ac:437
> > +if test "$with_unicode_backend" = "icu"; then
> > +    # TODO: use pkg-config (after CFLAGS in .pc files are cleaned up)
> > +    case "$host" in
> > +        *-*-darwin*)
> > +            UNICODE_CFLAGS="-I$srcdir/Source/JavaScriptCore/icu -I$srcdir/Source/WebCore/icu"
> > +            UNICODE_LIBS="-licucore"
> > +            ;;
> > +        *-*-mingw*)
> > +            UNICODE_CFLAGS=""
> > +            UNICODE_LIBS="-licuin -licuuc"
> > +            ;;
> > +        *)
> > +            AC_PATH_PROG(icu_config, icu-config, no)
> > +            if test "$icu_config" = "no"; then
> > +                AC_MSG_ERROR([Cannot find icu-config. The ICU library is needed.])
> > +            fi
> > +
> > +            # We don't use --cflags as this gives us a lot of things that we don't
> > +            # necessarily want, like debugging and optimization flags
> > +            # See man (1) icu-config for more info.
> > +            UNICODE_CFLAGS=`$icu_config --cppflags`
> > +            UNICODE_LIBS=`$icu_config --ldflags-libsonly`
> > +            ;;
> > +    esac
> > +fi
> 
> Can we use this moment to remove this work-around. Do you mind confirming that the pkg-config files for Windows are functional, at least?

Not sure about Windows, but I can't even get sensible information on Linux unless I play with `pkg-config --variable foo`.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.