[Webkit-unassigned] [Bug 77833] Get rid of Source/autotools/webkit.m4

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=77833





--- Comment #9 from Priit Laes (IRC: plaes) <plaes at plaes.org>  2012-02-06 09:27:50 PST ---
(In reply to comment #8)
> (In reply to comment #7)
> 
> > > > configure.ac:394
> > > > +PKG_CHECK_MODULES([GLIB], [glib-2.0 >= $GLIB_REQUIRED_VERSION])
> > > 
> > > I believe it's better to use AM_PATH_GLIB_2_0($GLIB_REQUIRED_VERSION) here, because it has support for pulling in GLib modules individually. See http://trac.webkit.org/changeset/106485. I'd like to have this patch in master too.
> > 
> > How about this then:
> > PKG_CHECK_MODULES([GLIB], [glib-2.0 >= $GLIB_REQUIRED_VERSION
> >     gmodule-2.0 gobject-2.0 gthread-2.0 gio-2.0])
> 
> It seems better to use the autoconfig glue that GLib provides. Is there any reason the PKG_CHECK_MODULES version is superior?

There's only thing favoring AM_PATH_GLIB - it tries to check (by compiling a small sample) whether library works correctly. Also, if you check the source of the AM_PATH_GLIB it's using pkg-config internally.

And last but not least, AM_PATH_GLIB seems to be just a historical relic reminding us about the good old times when pkg-config didn't yet exist (pre-2006)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.