[Webkit-unassigned] [Bug 98705] [EFL][WK2] Add Remote Web Inspector

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=98705





--- Comment #12 from Ryuan Choi <ryuan.choi at samsung.com>  2012-12-05 19:56:56 PST ---
(From update of attachment 177735)
View in context: https://bugs.webkit.org/attachment.cgi?id=177735&action=review

> Source/WebKit2/UIProcess/InspectorServer/efl/WebInspectorServerEfl.cpp:42
> +static String inspectorResourcePath()
> +{
> +    String inspectorFilesPath = WEB_INSPECTOR_INSTALL_DIR;
> +    if (access(inspectorFilesPath.utf8().data(), R_OK))
> +        inspectorFilesPath = WEB_INSPECTOR_DIR;
> +
> +    return inspectorFilesPath;
> +}

IMHO, how about moving this into WebCore/platform/efl to reduce duplication?

For example, EflInspectorUtilities.h?

In addition, don't we return "file://" + inspectorFilesPath ?

> Source/WebKit2/UIProcess/InspectorServer/efl/WebInspectorServerEfl.cpp:53
> +    String localPath = inspectorResourcePath() + ((path == "/") ? "/inspectorPageIndex.html" : path);

Can we improve this line using https://trac.webkit.org/wiki/EfficientStrings ?

> Source/WebKit2/UIProcess/InspectorServer/efl/WebInspectorServerEfl.cpp:54
> +    if (localPath.isNull())

I am wonering how localPath can be null

> Source/WebKit2/UIProcess/InspectorServer/efl/WebInspectorServerEfl.cpp:98
> +        builder.appendLiteral("\", \"inspectorUrl\": \"");
> +        builder.appendLiteral("/inspector.html?page=");

As one line?

> Source/WebKit2/UIProcess/efl/WebContextEfl.cpp:50
> +        String bindAddress = "127.0.0.1";

ASCIILiteral("...")

> Source/WebKit2/UIProcess/efl/WebContextEfl.cpp:54
> +        serverAddress.split(":", result);

':' ?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.