[Webkit-unassigned] [Bug 98705] [EFL][WK2] Add Remote Web Inspector

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=98705





--- Comment #11 from Seokju Kwon <seokju.kwon at samsung.com>  2012-12-05 19:10:07 PST ---
(In reply to comment #10)
> (From update of attachment 177479 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=177479&action=review
> 
> >> Source/WebKit2/UIProcess/efl/WebContextEfl.cpp:47
> >> +    initialized = true;
> > 
> > It doesnt seem initialized at this point, what if the below fails?
> 
> In Gtk port, it looks they wanted to initialize this variable only once. I think they used this as guard pointer to prevent to call more than once. 
> 
> > Source/WebKit2/UIProcess/gtk/WebContextGtk.cpp:61
> > +        initialized = WebInspectorServer::shared().listen(bindAddress, port); 
> initialized is to ensure initInspectorServer() is executed only once, so it should set to true always, even if the env var is not present or the server fails to run.
> https://bugs.webkit.org/show_bug.cgi?id=88094#c25
> 
> Don't initInspectorServer() be called only once ?

Sound reasonable.
Qt and GTK port are same (initInspectorServer() is executed only once).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.