[Webkit-unassigned] [Bug 103704] [EFL][WK2] Implement Accelerated2DCanvas on WK2 Efl port

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=103704





--- Comment #32 from Kyungjin Kim <gen.kim at samsung.com>  2012-12-04 18:51:48 PST ---
(In reply to comment #22)
> (In reply to comment #18)
> > Created an attachment (id=177177)
 --> (https://bugs.webkit.org/attachment.cgi?id=177177&action=review) [details] [details]
> > Patch
> 
> Canvas2DLayerEfl.h  -> There isnt any things specific to EFL(Atleast from the code I see here). 

With graphics surface implementation, it could be more EFL specific class. And I'm very careful about making it to a general class unless other ports intent to use it.
> 
> Two different approaches we could take:
> 1)As I see it, we can rename it for something more generic (i.e Canvas2DAcceleratedLayer or any other generic name) which could be reused in other places too (see my comments below, expanding on this front.)
> 2)Can/should we extend PlatformContextCairo to handle this functionality. 
> 
> There are common things between GraphicsContext3DPrivate and this class which could be shared. It would be good for us to have a base class which encapsulates the common functionality and than class deriving from it to handle 2DCanvas and 3D Canvas specific stuff. I guess this is out of scope for this changeset but we should do this at some point.
> 
> >>for both cases using GRAPHICS_SURFACE and no GRAPHICS_SURFACE because it is >>not enabled by default in EFL currently.
> >>  Graphics surface version of Accelerated2DCanvas will be implemented soon. 
> 
> This is true currently as WebGL is disabled by default.Currently we dont have any other use case for GRAPHICS_SURFACE (w.r.t EFL port atleast). However there is no dependency of GRAPHICS_SURFACE usage on WebGL (matter of doing some changes in configiration ??). Is the plan to use GraphicsSurface as the default path and fall back to accelerated canvas with no GRAPHICS_SURFACE (and of course software fallback) ??

May be no. If GRAPHICS_SURFACE is on graphics surface version of accelerated canvas will be used.
> 
> Feel free to ignore the below comment:
> IMHO,Apart from the compile time option, it would be nice to enable/disable this feature during run time (i.e like chrome). This would be quite handy to fix any regressions(software vs accelerated canvas), do some benchmarks as to what use cases do we really benefit etc.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.